On Wed, Jan 8, 2020 at 10:42 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, Jan 05, 2020 at 04:55:57PM -0600, jassisinghbrar@xxxxxxxxx wrote: > > --- /dev/null > > +++ b/drivers/usb/gadget/udc/max3420_udc.c > > @@ -0,0 +1,1333 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * MAX3420 Device Controller driver for USB. > > + * > > + * Author: Jaswinder Singh Brar <jaswinder.singh@xxxxxxxxxx> > > + * (C) Copyright 2019 Linaro Ltd > > + * > > + * Based on: > > + * o MAX3420E datasheet > > + * http://datasheets.maximintegrated.com/en/ds/MAX3420E.pdf > > + * o MAX342{0,1}E Programming Guides > > + * https://pdfserv.maximintegrated.com/en/an/AN3598.pdf > > + * https://pdfserv.maximintegrated.com/en/an/AN3785.pdf > > + * > > + * This file is licenced under the GPL v2. > > This line says that the SPDX line above is a lie :( > > Please fix this. > Sorry, that is a relic from forward porting the driver. I updated the copyright year (guess need to again) but missed that line. > As pennance, please re-read Documentation/process/license-rules.rst. > I will take a dozen lines each day before bed. Cheers still !