Hi Linus,
On Tue, 31 Dec 2019 at 18:50, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> Instead of using the legacy GPIO API and keeping track on
> polarity inversion semantics in the driver, switch to use
> GPIO descriptors for this driver and change all consumers
> in the process.
>
> This makes it possible to retire platform data completely:
> the only remaining platform data member was "wakeup" which
> was intended to make the vbus interrupt wakeup capable,
> but was not set by any users and thus remained unused. VBUS
> was not waking any devices up. Leave a comment about it so
> later developers using the platform can consider setting it
> to always enabled so plugging in USB wakes up the platform.
>
> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Cc: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> Cc: Daniel Mack <daniel@xxxxxxxxxx>
> Cc: Haojian Zhuang <haojian.zhuang@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> arch/arm/mach-s3c64xx/mach-smartq.c | 13 ++--
> --- a/arch/arm/mach-s3c64xx/mach-smartq.c
> +++ b/arch/arm/mach-s3c64xx/mach-smartq.c
> #include <asm/mach-types.h>
> @@ -124,15 +123,16 @@ static struct s3c2410_hcd_info smartq_usb_host_info = {
> .enable_oc = smartq_usb_host_enableoc,
> };
>
> -static struct gpio_vbus_mach_info smartq_usb_otg_vbus_pdata = {
> - .gpio_vbus = S3C64XX_GPL(9),
> - .gpio_pullup = -1,
> - .gpio_vbus_inverted = true,
> +static struct gpiod_lookup_table smartq_usb_otg_vbus_gpiod_table = {
> + .dev_id = "gpio-vbus",
> + .table = {
> + GPIO_LOOKUP("gpio-pxa", 9, "vbus", GPIO_ACTIVE_LOW),
IIUC the chip_label here should be "GPL", so we match the GPIO bank
properly. Otherwise looks good to me. With the typo fixed feel free to add
Acked-by: Sylwester Nawrocki <snawrocki@xxxxxxxxxx>
> + { },
> + },
> };
--
Regards,
Sylwester
