On Fri, Dec 06, 2019 at 04:56:52PM +0100, Daniele Palmas wrote: > Il giorno ven 6 dic 2019 alle ore 16:43 Johan Hovold > <johan@xxxxxxxxxx> ha scritto: > > > > > > > > > I wonder whether using option is the right thing to do here. We're just > > > > currently throwing everything modem related in here it seems. :) > > > > > > > > > > I understand your concern. At first, in fact, I tried to add support > > > for this in usb-serial-simple, but the change seemed to me more > > > impacting than the one I had to do for adding support in option. > > > > > > Let me know if you want me to continue investigating the > > > usb-serial-simple way or you have another advice. > > > > Yeah, I was thinking along those lines as well. Let me get me get back > > to you on that. > > > > Ok, thanks, I'll wait for your thoughts on that before submitting V3 > for the current patch. Sorry about the delay here. I think adding this to option/usb_wwan makes sense (e.g. only one driver needs to be enabled) so just move the flag handling to port_probe as we discussed in v2. Johan
