On Fri, Dec 13, 2019 at 08:16:18PM +0800, zhong jiang wrote: > Fixes the following compile error: > > drivers/usb/typec/tcpm/fusb302.o: In function `tcpm_get_current_limit': > fusb302.c:(.text+0x3ee): undefined reference to `extcon_get_state' > fusb302.c:(.text+0x422): undefined reference to `extcon_get_state' > fusb302.c:(.text+0x450): undefined reference to `extcon_get_state' > fusb302.c:(.text+0x48c): undefined reference to `extcon_get_state' > drivers/usb/typec/tcpm/fusb302.o: In function `fusb302_probe': > fusb302.c:(.text+0x980): undefined reference to `extcon_get_extcon_dev' > make: *** [vmlinux] Error 1 > > It is because EXTCON is build as a module, but FUSB302 is not. > > Suggested-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > --- > drivers/usb/typec/tcpm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig > index 72481bb..5b986d6 100644 > --- a/drivers/usb/typec/tcpm/Kconfig > +++ b/drivers/usb/typec/tcpm/Kconfig > @@ -32,6 +32,7 @@ endif # TYPEC_TCPCI > config TYPEC_FUSB302 > tristate "Fairchild FUSB302 Type-C chip driver" > depends on I2C > + depends on EXTCON || !EXTCON > help > The Fairchild FUSB302 Type-C chip driver that works with > Type-C Port Controller Manager to provide USB PD and USB > -- > 1.7.12.4 thanks, -- heikki
