Hi, On Tue, Oct 15, 2019 at 04:03:09PM +0100, Ben Dooks (Codethink) wrote: > The trace functions should have __iomem on the addr > pointers. Add __iomem to avoid the following warnings > from sparse: > > drivers/usb/musb/musb_core.c:253:55: warning: incorrect type in argument 2 (different address spaces) > drivers/usb/musb/musb_core.c:253:55: expected void const *addr > drivers/usb/musb/musb_core.c:253:55: got void const [noderef] <asn:2> *addr > drivers/usb/musb/musb_core.c:259:56: warning: incorrect type in argument 2 (different address spaces) > drivers/usb/musb/musb_core.c:259:56: expected void const *addr > drivers/usb/musb/musb_core.c:259:56: got void [noderef] <asn:2> *addr > drivers/usb/musb/musb_core.c:267:55: warning: incorrect type in argument 2 (different address spaces) > drivers/usb/musb/musb_core.c:267:55: expected void const *addr > drivers/usb/musb/musb_core.c:267:55: got void const [noderef] <asn:2> *addr > drivers/usb/musb/musb_core.c:273:56: warning: incorrect type in argument 2 (different address spaces) > drivers/usb/musb/musb_core.c:273:56: expected void const *addr > drivers/usb/musb/musb_core.c:273:56: got void [noderef] <asn:2> *addr > drivers/usb/musb/musb_core.c:383:55: warning: incorrect type in argument 2 (different address spaces) > drivers/usb/musb/musb_core.c:383:55: expected void const *addr > drivers/usb/musb/musb_core.c:383:55: got void const [noderef] <asn:2> *addr > drivers/usb/musb/musb_core.c:390:56: warning: incorrect type in argument 2 (different address spaces) > drivers/usb/musb/musb_core.c:390:56: expected void const *addr > drivers/usb/musb/musb_core.c:390:56: got void [noderef] <asn:2> *addr > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> Thanks for the patch. But checkpatch.pl complains that the author and Signed-off-by do not match. Can you please fix it and re-send? -Bin.