Hi Ajay, On Fri, Nov 22, 2019 at 04:43:47PM -0800, Ajay Gupta wrote: > From: Ajay Gupta <ajayg@xxxxxxxxxx> > > CCGx controller used on NVIDIA GPU card has two separate display > altmode for two DP pin assignments. UCSI specification doesn't > prohibits using separate display altmode. > > Current UCSI Type-C framework expects only one display altmode for > all DP pin assignment. This patch squashes two separate display > altmode into single altmode to support controllers with separate > display altmode. We first read all the alternate modes of connector > and then run through it to know if there are separate display > altmodes. If so, it prepares a new port altmode set after squashing > two or more separate altmodes into one. I didn't see any major issues with this. There were still few extra spaces etc., but I can clean those. Maybe it would have been good to mention in the commit message that the reason why we need those two separate alt modes, for what is in reality two separate pin configurations, is limitations in UCSI specification, but never mind. I still don't like the approach, but since I'm unable to explain my idea, or have time to write something for this myself, I don't want block this any longer. It does not add that much code, so once I have time, I can always try to improve it myself, right? Otherwise it's OK by me. I'll queue it up. thanks, -- heikki
