RE: [RFCv1 1/1] USB: EHCI: Do not return -EPIPE when hub is disconnected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Sent: maanantai 9. joulukuuta 2019 17.25
> To: Erkka Talvitie <erkka.talvitie@xxxxxxxxx>
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> claus.baumgartner@xxxxxxxxxx
> Subject: RE: [RFCv1 1/1] USB: EHCI: Do not return -EPIPE when hub is
> disconnected
> 
> On Mon, 9 Dec 2019, Erkka Talvitie wrote:
> 
> > > Ok, just to double check:
> > >
> > > I take the existing driver code (I will not apply the earlier RFC on
> > > top
> > of
> > > that) and apply one more check before the original stall check (that
is):
> > > } else if (QTD_CERR(token)) {
> > >
> > > The check that I will add is checking MMF bit && PID == IN, and this
> > > check comes right after the babble check, right?
> > >
> > > Good, seems like a simple change. Yet I still prefer to test the
change.
> > > Unfortunately that goes to the next week as we have a national
> > > holiday tomorrow.
> > > I will get back to you most likely on Monday.
> >
> > I tested this change and it removes the error messages from the output.
> 
> Great!  Okay, feel free to submit a new patch.

Thank you, a new patch was submitted.

> 
> Alan Stern

Erkka Talvitie




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux