Hi Linus, On 06.12.2019 10:58, Linus Walleij wrote: > On Fri, Dec 6, 2019 at 10:14 AM Marek Szyprowski > <m.szyprowski@xxxxxxxxxxx> wrote: > > BTW: > >> I really wonder why >> it worked fine with non-descriptor code and the ACTIVE_LOW DT flags... > The old code ignored the polarity flags in the device tree and > assumed everything was active high, that's how. It could as well > be hardcoded to 1337. Okay, then to restore current driver behavior after your patch, one has to change gpio flags in all dts to ACTIVE_HIGH... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland