Hi Linus, On Thu, Dec 05, 2019 at 03:22:00PM +0100, Linus Walleij wrote: > The DaVinci MUSB glue contains an optional GPIO line to > control VBUS power, convert this to use a GPIO descriptor > and augment the EVM board file to provide this descriptor. > > I can't get this driver to compile properly and it depends > on broken but when I didn get it to compile brokenly, it > did at least not complain about THIS code being broken so > I don't think I broke the driver any more than what it > already is. > > I did away with the ifdefs that do not work with > multiplatform anyway so the day someone decides to > resurrect the code, the path to get it working should be > easier as well since DaVinci is now multiplatform. Generally I don't take such patches unless they are part of the effort to un-broken the driver. But is this patch a prerequisite of any cleanup in DaVinci family or ARM architecture? What is the motivation of this patch? Sekhar/Tony, This DaVinci glue driver has been marked as BROKEN since 2013 and seems no one complained about it. Is there any development on the DaVinci devices still active? Does it make sense to remove this driver out of the kernel instead? -Bin.