Hello,
Gentle reminder...
On 11/22/2019 9:30 AM, Tejas Joglekar wrote:
> Hello Balbi,
> This is a critical patch fix for dwc3, can you please review ?
>
> On 11/13/2019 11:45 AM, Tejas Joglekar wrote:
>> This patch corrects the condition to kick the transfer without
>> giving back the requests when either request has remaining data
>> or when there are pending SGs. The && check was introduced during
>> spliting up the dwc3_gadget_ep_cleanup_completed_requests() function.
>>
>> Fixes: f38e35dd84e2 ("usb: dwc3: gadget: split dwc3_gadget_ep_cleanup_completed_requests()")
>>
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Tejas Joglekar <joglekar@xxxxxxxxxxxx>
>> ---
>> drivers/usb/dwc3/gadget.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index 86dc1db788a9..e07159e06f9a 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -2485,7 +2485,7 @@ static int dwc3_gadget_ep_cleanup_completed_request(struct dwc3_ep *dep,
>>
>> req->request.actual = req->request.length - req->remaining;
>>
>> - if (!dwc3_gadget_ep_request_completed(req) &&
>> + if (!dwc3_gadget_ep_request_completed(req) ||
>> req->num_pending_sgs) {
>> __dwc3_gadget_kick_transfer(dep);
>> goto out;
> Thanks & Regards,
>
> Tejas Joglekar
>
Thanks,
Tejas Joglekar
