On Mon, Nov 18, 2019 at 11:07:55AM +0100, Pacho Ramos wrote: > Hello, > > I would like to forward the patch that is being used for years in > Fedora and Gentoo to fix connectivity issues of JMicron devices with > UAS when they got into idle state: > https://bugzilla.redhat.com/show_bug.cgi?id=1260207 > https://bugs.gentoo.org/640082 > > The problem is still valid with current kernels, then, I guess the > patch wasn't forwarded here or got forgotten for some reason. This > patch works fine for current kernel 4.13.11 too Laura, any reason this patch was never sent upstream to us? Any objection for the patch below to be merged? thanks, greg k-h > From d02a55182307c01136b599fd048b4679f259a84e Mon Sep 17 00:00:00 2001 > From: Laura Abbott <labbott@xxxxxxxxxxxxxxxxx> > Date: Tue, 8 Sep 2015 09:53:38 -0700 > Subject: [PATCH] usb-storage: Disable UAS on JMicron SATA enclosure > > Steve Ellis reported incorrect block sizes and alignement > offsets with a SATA enclosure. Adding a quirk to disable > UAS fixes the problems. > > Reported-by: Steven Ellis <sellis@xxxxxxxxxx> > Signed-off-by: Laura Abbott <labbott@xxxxxxxxxxxxxxxxx> > --- > drivers/usb/storage/unusual_uas.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > index c85ea53..216d93d 100644 > --- a/drivers/usb/storage/unusual_uas.h > +++ b/drivers/usb/storage/unusual_uas.h > @@ -141,12 +141,15 @@ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_NO_ATA_1X), > > -/* Reported-by: Takeo Nakayama <javhera@xxxxxxx> */ > +/* > + * Initially Reported-by: Takeo Nakayama <javhera@xxxxxxx> > + * UAS Ignore Reported by Steven Ellis <sellis@xxxxxxxxxx> > + */ > UNUSUAL_DEV(0x357d, 0x7788, 0x0000, 0x9999, > "JMicron", > "JMS566", > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > - US_FL_NO_REPORT_OPCODES), > + US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS), > > /* Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx> */ > UNUSUAL_DEV(0x4971, 0x1012, 0x0000, 0x9999, > -- > 2.4.3 >
