On Thu, Nov 14, 2019 at 04:33:56PM +0100, Andrey Konovalov wrote:
> On Thu, Nov 14, 2019 at 4:08 PM Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote:
> > On Fri, Nov 8, 2019 at 10:17 PM Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > > +static void gadget_reset(struct usb_gadget *gadget)
> > > > +{
> > > > + pr_debug("ignoring\n");
> > > > +}
> > >
> > > I think you don't even need functions for these, right? If not, just
> > > remove. If you do, we should fix the gadget core to not require them :)
> >
> > Will do in v2.
>
> Actually, I just hit that Dummy HCD/UDC requires a disconnect callback
> to be present. And I assume other UDCs might do the same, so I'd
> rather include the callbacks just in case. WDYT?
If they require it to be present then yes, leave all of these.
thanks,
greg k-h
