On Fri, 12 Jun 2009, Alek Du wrote:
> From ddad0667161f801b3477de5d93c7321b44dfb9f9 Mon Sep 17 00:00:00 2001
> From: Alek Du <alek.du@xxxxxxxxx>
> Date: Wed, 10 Jun 2009 15:20:21 +0800
> Subject: [PATCH] EHCI: Support Intel Moorestown MPH and OTG host
>
> The Intel Moorestown platform has EHCI MPH and EHCI OTG host. This patch adds
> PCI probe part for them. The HNP part and SRAM part will be added in another
> patch. This patch depends on the OTG transceive and OTG client patch from Hang
> Yuan that should be accepted already.
This is a lot cleaner now. Good work.
> diff --git a/drivers/usb/host/ehci-langwell-pci.c b/drivers/usb/host/ehci-langwell-pci.c
> new file mode 100644
> index 0000000..f78a756
> --- /dev/null
> +++ b/drivers/usb/host/ehci-langwell-pci.c
> +static int ehci_langwell_probe(struct pci_dev *pdev,\
> + const struct pci_device_id *id)
> +{
> + struct hc_driver *driver;
> + struct langwell_otg *iotg;
> + struct otg_transceiver *otg;
> + struct usb_hcd *hcd;
> + struct ehci_hcd *ehci;
> + int irq;
> + int retval;
> +
> + pr_debug("initializing Langwell USB OTG Host Controller\n");
> +
> + irq = pdev->irq;
> +
> + if (!id)
> + return -EINVAL;
> + driver = (struct hc_driver *)id->driver_data;
> + if (!driver)
> + return -EINVAL;
> +
> + pdev->current_state = PCI_D0;
> + pdev->dev.power.power_state = PMSG_ON;
Do you really need these two line? Probably the equivalent code in
hcd-pci.c isn't needed either.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
