On Fri, Jun 12, 2009 at 04:41:45PM +0200, Alberto Panizzo wrote:
> > +static inline int usb_xcvr_set_vbus(struct usb_xcvr *xcvr, bool en)
> > +{
> > + if (xcvr->set_vbus)
> > + return xcvr->set_vbus(xcvr, en);
> > +
> > + if (xcvr->driver && xcvr->driver->set_vbus)
> > + xcvr->driver->set_vbus(xcvr, en);
> > +
> > + return -EINVAL;
> > +}
>
> Maybe you want this:
>
> static inline int usb_xcvr_set_vbus(struct usb_xcvr *xcvr, bool en)
> {
> if (xcvr->set_vbus)
> return xcvr->set_vbus(xcvr, en);
>
> if (xcvr->driver && xcvr->driver->set_vbus)
> - xcvr->driver->set_vbus(xcvr, en);
> + return xcvr->driver->set_vbus(xcvr, en);
>
> return -EINVAL;
> }
>
> Otherwise your code will return always -EINVAL, in other hands also ulpi.c need
> modifications..
Yes, Valentin Longchamp already mentioned that. It's fixed in my local
tree and will be part of my next round of submission.
Did you have success testing the whole thing? Does ULPI communication
work for you? I'm still struggling with the directly access transceivers
or the viewports, but it might be the hardware as well ...
Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
