On Mon, Nov 04, 2019 at 10:48:50PM +0800, Mao Wenan wrote: > The USB role switch class is, after all, > not useful by itself. Hiding USB_ROLE_SWITCH > so we can avoid any of the pitfalls associated > with user-visible symbols and "select". > > Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx> > --- > drivers/usb/roles/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/roles/Kconfig b/drivers/usb/roles/Kconfig > index f8b31aa..1da58d4 100644 > --- a/drivers/usb/roles/Kconfig > +++ b/drivers/usb/roles/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > > config USB_ROLE_SWITCH > - tristate "USB Role Switch Support" > + tristate > help > USB Role Switch is a device that can select the USB role - host or > device - for a USB port (connector). In most cases dual-role capable You didn't actually convert the "depends on USB_ROLE_SWTICH" to "select USB_ROLE_SWITCH" before this. You also left the help text that is now useless. I really think that instead of this, we should just convert all "select USB_ROLE_SWTICH" to "depends on USB_ROLE_SWITCH". thanks, -- heikki
