> On Oct 28, 2019, at 17:41, Hayes Wang <hayeswang@xxxxxxxxxxx> wrote: > > Kai-Heng Feng [mailto:kai.heng.feng@xxxxxxxxxxxxx] >> Sent: Friday, October 25, 2019 6:59 PM > [...] >> -#define REALTEK_USB_DEVICE(vend, prod) \ >> +#define REALTEK_USB_DEVICE(vend, prod, info) \ >> .match_flags = USB_DEVICE_ID_MATCH_DEVICE | \ >> USB_DEVICE_ID_MATCH_INT_CLASS, \ >> .idVendor = (vend), \ >> .idProduct = (prod), \ >> - .bInterfaceClass = USB_CLASS_VENDOR_SPEC \ >> + .bInterfaceClass = USB_CLASS_VENDOR_SPEC, \ >> + .driver_info = (info) \ >> }, \ >> { \ >> .match_flags = USB_DEVICE_ID_MATCH_INT_INFO | \ >> @@ -6739,25 +6740,26 @@ static void rtl8152_disconnect(struct >> usb_interface *intf) >> .idProduct = (prod), \ >> .bInterfaceClass = USB_CLASS_COMM, \ >> .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \ >> - .bInterfaceProtocol = USB_CDC_PROTO_NONE >> + .bInterfaceProtocol = USB_CDC_PROTO_NONE, \ >> + .driver_info = (info) \ > > This part is for ECM mode. Add driver_info here is useless, > because it is never be used. The driver always changes > the ECM mode to vendor mode. Thanks for the explanation. Since we are going to compare IDs directly in probe(), I'll just drop this patch. Kai-Heng > > Best Regards, > Hayes > >
