Re: [PATCH 12/18] usb: typec: ucsi: acpi: Move to the new API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Heikki,

I love your patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[cannot apply to v5.4-rc4 next-20191021]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Heikki-Krogerus/usb-typec-API-improvements/20191022-013906
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-dirty
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/typec/ucsi/ucsi_acpi.c:54:9: sparse: sparse: incorrect type in argument 2 (different address spaces) @@    expected void const *from @@    got void [noderevoid const *from @@
>> drivers/usb/typec/ucsi/ucsi_acpi.c:54:9: sparse:    expected void const *from
   drivers/usb/typec/ucsi/ucsi_acpi.c:54:9: sparse:    got void [noderef] <asn:2> *
>> drivers/usb/typec/ucsi/ucsi_acpi.c:64:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@    expected void *to @@    got void [noderef] <asvoid *to @@
>> drivers/usb/typec/ucsi/ucsi_acpi.c:64:9: sparse:    expected void *to
   drivers/usb/typec/ucsi/ucsi_acpi.c:64:9: sparse:    got void [noderef] <asn:2> *

vim +54 drivers/usb/typec/ucsi/ucsi_acpi.c

    43	
    44	static int ucsi_acpi_read(struct ucsi *ucsi, unsigned int offset,
    45				  void *val, size_t val_len)
    46	{
    47		struct ucsi_acpi *ua = ucsi_get_drvdata(ucsi);
    48		int ret;
    49	
    50		ret = ucsi_acpi_dsm(ua, UCSI_DSM_FUNC_READ);
    51		if (ret)
    52			return ret;
    53	
  > 54		memcpy(val, ua->base + offset, val_len);
    55	
    56		return 0;
    57	}
    58	
    59	static int ucsi_acpi_async_write(struct ucsi *ucsi, unsigned int offset,
    60					 const void *val, size_t val_len)
    61	{
    62		struct ucsi_acpi *ua = ucsi_get_drvdata(ucsi);
    63	
  > 64		memcpy(ua->base + offset, val, val_len);
    65	
    66		return ucsi_acpi_dsm(ua, UCSI_DSM_FUNC_WRITE);
    67	}
    68	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux