On Wed, Oct 16, 2019 at 7:26 AM David Howells <dhowells@xxxxxxxxxx> wrote: > > Btw, is there any point in __wake_up_sync_key() taking a nr_exclusive > argument since it clears WF_SYNC if nr_exclusive != 1 and doesn't make sense > to be >1 anyway. Ack, looks sane to me. We have _very_ few users of nr_exclusive. I wonder if it's even worth having at all, but it's definitely not worth it here. I'd love for nr_exclusive to go away and be replaced by WF_ALL instead. Right now it looks like there is one SGI driver that uses it, and the sbitmap code. That was all I could find. Oh well. You removing one case is at last a small amount of progress. Linus