> -----Original Message----- > From: Alan Cox [mailto:alan@xxxxxxxxxxxxxxxxxxx] > Sent: Monday, June 08, 2009 2:52 AM > To: Rory Filer > Cc: Elina Pasheva; gregkh@xxxxxxx; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: Retracting All Current Patches to Sierra.c From Sierra > Wireless for Now > > Thanks for posting this. I hadn't realised quite how pear-shaped the > sierra merge had gone. > > > Normally I just fix things up as I go but the 8 patch set I was sent > included some changes where it really needed the original authors to > take > a quick glance over the changeset and tweak it, otherwise it was too > likely to cause breakage. I'm quite happy to guess (and from your mail > it > seems I will have to) but having someone at sierra do the merge would > have been preferable. > I tell you what, if you can provide us with a baseline file from your tree to start merging back our changes we send back a revised series of patches to you. Or, if you have already merged the changes into the file we'd be happy to take a look at it and send back comments, etc. > The blacklist patch I'll take a look at the history of, the copy in > your > email is mangled (probably been "outlooked") but if the original hit > the > mailing lists I'll fish it out from there. > > Alan Yes, outlooked. Hi Alan, Please see my comments inserted above. We don't want to put anyone to extra effort here which is why I suggested we wait until your, Alan Stearn's and anyone else who happens to be making changes to the usbserial.c drivers is all done. I suppose the danger is that 2.6.30 might get released before we can fix the broken logic leaving sierra.c in a bit of a mess. Sorry for all the bother on this. Regards Rory Filer -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html