On Fri, Oct 04, 2019 at 06:08:13PM +0300, Heikki Krogerus wrote: > @@ -1103,7 +1113,8 @@ port_type_store(struct device *dev, struct device_attribute *attr, > int ret; > enum typec_port_type type; > > - if (!port->cap->port_type_set || port->cap->type != TYPEC_PORT_DRP) { > + if (port->cap->type != TYPEC_PORT_DRP || !port->cap->port_type_set || > + (!port->ops && !port->ops->port_type_set)) { This is still broken :-/ -- heikki