On Wed, Oct 02, 2019 at 10:39:54AM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 02, 2019 at 11:30:34AM +0300, Mika Westerberg wrote: > > On Tue, Oct 01, 2019 at 06:27:42PM +0200, Oliver Neukum wrote: > > > Am Dienstag, den 01.10.2019, 18:07 +0300 schrieb Mika Westerberg: > > > > > > Hi, > > > > > > > OK, but does that break existing .configs? I mean if you have already > > > > CONFIG_THUNDERBOLT in your .config/defconfig does it now just get > > > > dropped silently? > > > > > > People will have to look at this new stuff anyway. > > > > > > > For example firewire has CONFIG_FIREWIRE even though the "standard" name > > > > is IEEE 1394. I was thinking maybe we can do the same for > > > > USB4/Thunderbolt > > > > > > USB and Thunderbolt used to be distinct protocols. Whereas Firewire > > > was just a colloquial name for IEEE1394. Please be wordy here. > > > "Unified support for USB4 and Thunderbolt4" > > > > OK. > > > > I've been thinking this bit more and since Thunderbolt will stick around > > as well (it basically implements all the optional USB4 features and > > more) so would it make sense to have the Kconfig option be > > CONFIG_THUNDERBOLT_USB4 (or CONFIG_USB4_THUNDERBOLT)? That should cover > > both. > > I would stick with CONFIG_USB4 but put both in the Kconfig text. Again, > it will be easier to handle this over time. OK, thanks Greg! > > Comments? > > > > Also does anyone have any thoughts about keeping the driver under > > drivers/thunderbolt vs. moving it under usb like > > drivers/usb/thunderbolt? I'm thinking if anyone not familiar with this > > tries to enable support for USB4 so the first place he/she probably > > looks is under "USB support" menuconfig entry. > > You are not sharing/needing any of the drivers/usb/ code just yet, > right? Yes, that's correct. > I imagine that will happen "soon" and when it does, then sure, > moving stuff is fine with me. OK thanks!
