Hi Heikki > -----Original Message----- > From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > Sent: Thursday, September 26, 2019 3:07 AM > To: Ajay Gupta <ajayg@xxxxxxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx > Subject: [PATCH 00/14] usb: typec: UCSI driver overhaul > > Hi Ajay, > > Here's the pretty much complete rewrite of the I/O handling that I was > talking about. The first seven patches are not actually related to > this stuff, but I'm including them here because the rest of the series > is made on top of them. I'm including also that fix patch I send you > earlier. > > After this it should be easier to handle quirks. My idea how to handle > the multi-instance connector alt modes is that we "emulate" the PPM in > ucsi_ccg.c in order to handle them, so ucsi.c is not touched at all. > > We can now get the connector alternate modes that the actual > controller supplies during probe - before registering the ucsi > interface How can ucsi_ccg.c get the connector alternate modes before registering ucsi interface? PPM reset, notification enable, etc. is done during ucsi registration. UCSI spec says: " The only commands the PPM is required to process in the "PPM Idle (Notifications Disabled)" state are SET_NOTIFICATION_ENABLE and PPM_RESE" Also, it doesn't look correct if ucsi_ccg.c has to replicate most of the stuff done in ucsi_init() of ucsi.c. Thanks > nvpublic > - and squash all alt modes with the same SVID into one that > we supply to the ucsi.c when ever it sends GET_ALTERNATE_MODES > command. Also other alt mode commands like SET_NEW_CAM can have > special processing in ucsi_ccg.c and ucsi_ccg.c alone. There should > not be any problem with that anymore. > > thanks, > > Heikki Krogerus (14): > usb: typec: Copy everything from struct typec_capability during > registration > usb: typec: Introduce typec_get_drvdata() > usb: typec: Separate the operations vector > usb: typec: tcpm: Start using struct typec_operations > usb: typec: tps6598x: Start using struct typec_operations > usb: typec: ucsi: Start using struct typec_operations > usb: typec: Remove the callback members from struct typec_capability > usb: typec: ucsi: ccg: Remove run_isr flag > usb: typec: ucsi: Simplified interface registration and I/O API > usb: typec: ucsi: acpi: Move to the new API > usb: typec: ucsi: ccg: Move to the new API > usb: typec: ucsi: Remove the old API > usb: typec: ucsi: Remove struct ucsi_control > usb: typec: ucsi: Remove all bit-fields > > drivers/usb/typec/class.c | 125 +++--- > drivers/usb/typec/tcpm/tcpm.c | 47 +-- > drivers/usb/typec/tps6598x.c | 49 +-- > drivers/usb/typec/ucsi/displayport.c | 26 +- > drivers/usb/typec/ucsi/trace.c | 11 - > drivers/usb/typec/ucsi/trace.h | 79 +--- > drivers/usb/typec/ucsi/ucsi.c | 592 ++++++++++++++------------- > drivers/usb/typec/ucsi/ucsi.h | 410 +++++++------------ > drivers/usb/typec/ucsi/ucsi_acpi.c | 96 ++++- > drivers/usb/typec/ucsi/ucsi_ccg.c | 214 ++++------ > include/linux/usb/typec.h | 38 +- > 11 files changed, 785 insertions(+), 902 deletions(-) > > -- > 2.23.0
