On Wed, Sep 11, 2019 at 10:24:33AM +0530, Chandana Kishori Chiluveru wrote: > Add documentation for the interconnects and interconnect-names > bindings for USB as detailed by bindings/interconnect/interconnect.txt. This isn't a generic binding for USB, but for the qcom,dwc3, the commit message (including subject) should reflect this. nit: you might want to replace 'bindings' with 'properties'. > Signed-off-by: Chandana Kishori Chiluveru <cchiluve@xxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/usb/qcom,dwc3.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt b/Documentation/devicetree/bindings/usb/qcom,dwc3.txt > index cb695aa..7e9cb97 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.txt > @@ -33,6 +33,16 @@ Optional clocks: > > Optional properties: > - resets: Phandle to reset control that resets core and wrapper. > +- interconnects: Pairs of phandles and interconnect provider specifier consistency nit: should be either 'phandle' & 'specifier' or 'phandles' & 'specifiers'.