On Mon, Jul 29, 2019 at 5:36 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > On Sun, Jul 28, 2019 at 07:06:31PM -0500, Gustavo A. R. Silva wrote: > > Mark switch cases where we are expecting to fall through. > > > > This patch fixes the following warnings: > > > > drivers/usb/phy/phy-ab8500-usb.c: In function 'ab8500_usb_link_status_update': > > drivers/usb/phy/phy-ab8500-usb.c:424:9: warning: this statement may fall through [-Wimplicit-fallthrough=] > > event = UX500_MUSB_RIDB; > > ~~~~~~^~~~~~~~~~~~~~~~~ > > drivers/usb/phy/phy-ab8500-usb.c:425:2: note: here > > case USB_LINK_NOT_CONFIGURED_8500: > > ^~~~ > > drivers/usb/phy/phy-ab8500-usb.c:440:9: warning: this statement may fall through [-Wimplicit-fallthrough=] > > event = UX500_MUSB_RIDC; > > ~~~~~~^~~~~~~~~~~~~~~~~ > > drivers/usb/phy/phy-ab8500-usb.c:441:2: note: here > > case USB_LINK_STD_HOST_NC_8500: > > ^~~~ > > drivers/usb/phy/phy-ab8500-usb.c:459:9: warning: this statement may fall through [-Wimplicit-fallthrough=] > > event = UX500_MUSB_RIDA; > > ~~~~~~^~~~~~~~~~~~~~~~~ > > drivers/usb/phy/phy-ab8500-usb.c:460:2: note: here > > case USB_LINK_HM_IDGND_8500: > > ^~~~ > > drivers/usb/phy/phy-ab8500-usb.c: In function 'ab8505_usb_link_status_update': > > drivers/usb/phy/phy-ab8500-usb.c:332:9: warning: this statement may fall through [-Wimplicit-fallthrough=] > > event = UX500_MUSB_RIDB; > > ~~~~~~^~~~~~~~~~~~~~~~~ > > drivers/usb/phy/phy-ab8500-usb.c:333:2: note: here > > case USB_LINK_NOT_CONFIGURED_8505: > > ^~~~ > > drivers/usb/phy/phy-ab8500-usb.c:352:9: warning: this statement may fall through [-Wimplicit-fallthrough=] > > event = UX500_MUSB_RIDC; > > ~~~~~~^~~~~~~~~~~~~~~~~ > > drivers/usb/phy/phy-ab8500-usb.c:353:2: note: here > > case USB_LINK_STD_HOST_NC_8505: > > ^~~~ > > drivers/usb/phy/phy-ab8500-usb.c:370:9: warning: this statement may fall through [-Wimplicit-fallthrough=] > > event = UX500_MUSB_RIDA; > > ~~~~~~^~~~~~~~~~~~~~~~~ > > drivers/usb/phy/phy-ab8500-usb.c:371:2: note: here > > case USB_LINK_HM_IDGND_8505: > > ^~~~ > > > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> Acked-by: Olof Johansson <olof@xxxxxxxxx> Felipe, Greg, this is still throwing warnings, several months later -- patch was never applied. Mind picking it up as a fix to get a quieter build? Thanks, -Olof
