RE: [PATCH v4 2/3] usb: renesas_usbhs: enable DVSE interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Veeraiyan-san,

> From: veeraiyan chidambaram, Sent: Tuesday, September 10, 2019 6:31 PM
> 
> Hello shimoda-san,
> 
> Thanks for point out checkpatch warning. After resolving checkpatch warning,
> below  checkpatch warning is seen.
> 
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #23:
> [1] commit f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")

I checked other commit log, and it seems adding a new line is better like below:

[1] commit f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common
    code")

JFYI (out-of-topic though), checkpatch.pl doesn't warn if a "Fixes:" tag with
more than 75 chars like following commit [2].

[2]
---
commit d950fd992ef89f39ff8908f389ed6cbd2fdc0513
Author: Niklas Söderlund <***>
Date:   Wed Feb 13 17:07:54 2019 -0500

    media: rcar-vin: Fix lockdep warning at stream on

    Changes to v4l2-fwnode in commit [1] triggered a lockdep warning in
    rcar-vin. The first attempt to solve this warning in the rcar-vin driver
    was incomplete and only pushed the warning to happen at stream on time
    instead of at probe time.

    This change reverts the incomplete fix and properly fixes the warning by
    removing the need to hold the rcar-vin specific group lock when calling
    v4l2_async_notifier_parse_fwnode_endpoints_by_port(). And instead takes
    it in the callback where it's really needed.

    [1] commit eae2aed1eab9bf08 ("media: v4l2-fwnode: Switch to
    v4l2_async_notifier_add_subdev")

    Fixes: 6458afc8c49148f0 ("media: rcar-vin: remove unneeded locking in async callbacks")
<snip>
---

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux