Hi Heikki, > > CCGx controller used on NVIDIA GPU card has two separate display > > altmode for two DP pin assignments. UCSI specification doesn't > > prohibits using separate display altmode. > > > > Current UCSI Type-C framework expects only one display altmode for all > > DP pin assignment. This patch squashes two separate display altmode > > into single altmode to support controllers with separate display > > altmode. We first read all the alternate modes of connector and then > > run through it to know if there are separate display altmodes. If so, > > it prepares a new port altmode set after squashing two or more > > separate altmodes into one. > > This patch has still some stylistic issues (like the comments: please use the > same style that was used previously in the driver), Ok, I will fix them in v5. > but besides those, I'm still not sure I understand why couldn't we isolate > the solution to ucsi_ccg.c. Please check my comments at [1] explaining why it can't be isolated to ucsi_ccg.c. [1] https://marc.info/?l=linux-usb&m=156625373324903&w=2 Thanks > nvpublic > I have to take a better look at this next week. > > I'm sorry this takes so long. > > Br, > > -- > heikki
