Hi Veeraiyan,
Thank you for the patch!
> From: Veeraiyan Chidambaram, Sent: Wednesday, September 4, 2019 11:48 PM
<snip>
> --- a/drivers/usb/gadget/udc/renesas_usb3.c
> +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> @@ -767,6 +767,20 @@ static void usb3_irq_epc_int_1_resume(struct renesas_usb3 *usb3)
> usb3_transition_to_default_state(usb3, false);
> }
>
> +static void usb3_irq_epc_int_1_suspend(struct renesas_usb3 *usb3)
> +{
> + usb3_disable_irq_1(usb3, USB_INT_1_B2_SPND);
> +
> + if (usb3->driver &&
> + usb3->driver->suspend &&
As I mentioned on v1 patch [1], I'd like to remove these conditions.
After fixed it,
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
[1] https://patchwork.kernel.org/patch/11129797/#22862513
Best regards,
Yoshihiro Shimoda
> + usb3->gadget.speed != USB_SPEED_UNKNOWN &&
> + usb3->gadget.state != USB_STATE_NOTATTACHED) {
> + if (usb3->driver && usb3->driver->suspend)
> + usb3->driver->suspend(&usb3->gadget);
> + usb_gadget_set_state(&usb3->gadget, USB_STATE_SUSPENDED);
> + }
> +}
> +
> static void usb3_irq_epc_int_1_disable(struct renesas_usb3 *usb3)
> {
> usb3_stop_usb3_connection(usb3);
> @@ -852,6 +866,9 @@ static void usb3_irq_epc_int_1(struct renesas_usb3 *usb3, u32 int_sta_1)
> if (int_sta_1 & USB_INT_1_B2_RSUM)
> usb3_irq_epc_int_1_resume(usb3);
>
> + if (int_sta_1 & USB_INT_1_B2_SPND)
> + usb3_irq_epc_int_1_suspend(usb3);
> +
> if (int_sta_1 & USB_INT_1_SPEED)
> usb3_irq_epc_int_1_speed(usb3);
>
> --
> 2.7.4
