On Wed, Jun 3, 2009 at 07:15, Sergei Shtylyov wrote: > Mike Frysinger wrote: >> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx> >> >> Only allow USE_MODE1 when the Blackfin part is not affected by anomaly >> 05000456 (USB Receive Interrupt Is Not Generated in DMA Mode 1) since we > > Hm, is it supposed to be generated in mode 1? Or do you mean that > it's not generated for the short packet as well? anomaly 450 and 456 are different issues >> +#ifdef CONFIG_BLACKFIN >> +# undef USE_MODE1 >> +# if !ANOMALY_05000456 >> +# define USE_MODE1 >> > > Why #undef and then #define? this is standard ifdef style: force a sane state before defining things -mike -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html