Re: [PATCH v3 2/2] usb: roles: intel: Enable static DRD mode for role switch

[Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>]

Hi,

>  static int intel_xhci_usb_set_role(struct device *dev, enum usb_role role)
> @@ -44,7 +52,7 @@ static int intel_xhci_usb_set_role(struct device *dev, enum usb_role role)
>  	struct intel_xhci_usb_data *data = dev_get_drvdata(dev);
>  	unsigned long timeout;
>  	acpi_status status;
> -	u32 glk, val;
> +	u32 glk, val, drd_config;

I guess you need to fix that. While at it, please introduce it on its
own line:

        u32 drd_config = DRD_CONFIG_DYNAMIC;


thanks,

-- 
heikki