Re: [PATCH v2] usb: avoid PM error messages during resume if a device was disconnected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 03 June 2009, Alan Stern wrote:
> On Wed, 3 Jun 2009, Rafael J. Wysocki wrote:
> 
> > > +	/* Avoid PM error messages for devices disconnected while suspended
> > > +	 * as we'll display regular disconnect messages just a bit later.
> > > +	 */
> > > +	if (status == -ENODEV)
> > > +		return 0;
> > > +	return status;
> > 
> > + return status == -ENODEV ? 0 : status;
> > 
> > maybe?
> > 
> > >  }
> > >  
> > >  #endif /* CONFIG_PM */
> 
> Personally, I would do:
> 
> 	if (status == -ENODEV)
> 		status = 0;
> 	return status;
> 
> It doesn't make any difference; they are all equally good.
> 
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

OK

Am I supposed to take this patch directly or push it to Greg?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux