On 22-08-2019 14:42, Thierry Reding wrote: > On Thu, Aug 08, 2019 at 03:07:25PM +0530, Nagarjuna Kristam wrote: >> This patch adds UDC driver for tegra XUSB 3.0 device mode controller. >> XUSB device mode controller supports SS, HS and FS modes >> >> Based on work by: >> Mark Kuo <mkuo@xxxxxxxxxx> >> Hui Fu <hfu@xxxxxxxxxx> >> Andrew Bresticker <abrestic@xxxxxxxxxxxx> >> >> Signed-off-by: Nagarjuna Kristam <nkristam@xxxxxxxxxx> >> Acked-by: Thierry Reding <treding@xxxxxxxxxx> >> --- >> drivers/usb/gadget/udc/Kconfig | 11 + >> drivers/usb/gadget/udc/Makefile | 1 + >> drivers/usb/gadget/udc/tegra_xudc.c | 3808 +++++++++++++++++++++++++++++++++++ >> 3 files changed, 3820 insertions(+) >> create mode 100644 drivers/usb/gadget/udc/tegra_xudc.c >> >> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig >> index ef0259a..fe6028e 100644 >> --- a/drivers/usb/gadget/udc/Kconfig >> +++ b/drivers/usb/gadget/udc/Kconfig >> @@ -440,6 +440,17 @@ config USB_GADGET_XILINX >> dynamically linked module called "udc-xilinx" and force all >> gadget drivers to also be dynamically linked. >> >> +config USB_TEGRA_XUDC >> + tristate "NVIDIA Tegra Superspeed USB 3.0 Device Controller" >> + depends on ARCH_TEGRA >> + select USB_ROLE_SWITCH >> + help >> + Enables NVIDIA Tegra USB 3.0 device mode controller driver. >> + >> + Say "y" to link the driver statically, or "m" to build a >> + dynamically linked module called "tegra_xudc" and force all >> + gadget drivers to also be dynamically linked. >> + >> source "drivers/usb/gadget/udc/aspeed-vhub/Kconfig" >> >> # >> diff --git a/drivers/usb/gadget/udc/Makefile b/drivers/usb/gadget/udc/Makefile >> index 897f648..1c55c96 100644 >> --- a/drivers/usb/gadget/udc/Makefile >> +++ b/drivers/usb/gadget/udc/Makefile >> @@ -24,6 +24,7 @@ obj-$(CONFIG_USB_BCM63XX_UDC) += bcm63xx_udc.o >> obj-$(CONFIG_USB_FSL_USB2) += fsl_usb2_udc.o >> fsl_usb2_udc-y := fsl_udc_core.o >> fsl_usb2_udc-$(CONFIG_ARCH_MXC) += fsl_mxc_udc.o >> +obj-$(CONFIG_USB_TEGRA_XUDC) += tegra_xudc.o > > Nit: I have a slight preference for tegra-xudc.o over tegra_xudc.o. We > use dashes rather than underscores pretty consistently on Tegra, so it > would be good to keep the same pattern here, unless somebody feels > strongly about the underscore. > > It doesn't matter that much because module utilities treat them the same > way I think, so the Acked-by remains valid either way. > > Thierry > Thierry, Reason to keep tegra_xudc.c instead of tegra-xudc.c is to inline with local file naming. I will use tegra-xudc.c name in next version, to be inline with other tegra files across kernel. Thanks, Nagarjuna
