Re: [PATCH] usb: usb251xb: drop some unused defines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 19, 2019 at 12:41:04PM +0200, Greg KH wrote:
> On Mon, Aug 19, 2019 at 12:02:11PM +0200, Uwe Kleine-König wrote:
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> >  drivers/usb/misc/usb251xb.c | 5 -----
> >  1 file changed, 5 deletions(-)
> 
> I can't take a patch without any changelog text.

So I am supposed to repeat the Subject's content in the body? I
completely agree that an expressive changelog is important for changes
that actually change something. But it seems silly to me to describe
something trivial in more words than necessary. There is zero added
value; only added noise.

> And you forgot to cc: the usb maintainer, so there's no way this was
> going to get merged :)

I would have expected that it is fine to direct to the contacts listed
in the "MICROCHIP USB251XB DRIVER" section of MAINTAINERS and then let
the people there care for forwarding. (And other than that it seems I
catched the attention of the usb maintainer :-)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux