On Tue, 2 Jun 2009, Greg KH wrote: > On Mon, Jun 01, 2009 at 02:39:35PM -0400, Alan Stern wrote: > > Greg: > > > > Is there any reason why the usb_serial_device_probe() and > > usb_serial_device_remove() functions in bus.c go through all this > > try_module_get business? The driver core already insures that the > > module is pinned, because these routines are called only while the > > driver is bound to the upper-level usb_serial device. > > I think it might have been left over from before I added that logic to > the driver core to ensure things are "pinned". Are you sure that if > that logic is removed we will still have the proper reference counting > correct? Sure. You don't see anything similar in the probe/remove methods for other buses. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
