I was looking at this code again today and I'm still convinced this patch is correct. Should I resend? regards, dan carpenter On Fri, Feb 23, 2018 at 03:33:00PM +0300, Dan Carpenter wrote: > The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's > a no-op because of the & vs | typo. This bug predates git and it was > only discovered using static analysis so it must not affect too many > people in real life. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > Not tested. > > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > index 3e2474959735..7679fb583e41 100644 > --- a/drivers/usb/host/ohci-pxa27x.c > +++ b/drivers/usb/host/ohci-pxa27x.c > @@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) > uhcrhda |= RH_A_NPS; > break; > case PMM_GLOBAL_MODE: > - uhcrhda &= ~(RH_A_NPS & RH_A_PSM); > + uhcrhda &= ~(RH_A_NPS | RH_A_PSM); > break; > case PMM_PERPORT_MODE: > uhcrhda &= ~(RH_A_NPS); > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
