Hi,
Rick Tseng <rtseng@xxxxxxxxxx> writes:
Hi Mathias,
Thanks for suggestion.
The reason I do not use xhci_handshake() is we get build fail when configuring below as module:
USB_XHCI_HCD = m
USB_XHCI_PCI = m
Fail message as below:
ERROR: "xhci_handshake" [drivers/usb/host/xhci-pci.ko] undefined!
So I write my own function to check CNR.
Adding EXPORT_SYMBOL_GPL(xhci_handshake) after the xhci_handshake() function in xhci.c
should solve that.
But I agree with Felipe that checking for Controller Not Ready (CNR)
is useful for any xHCI host, not just PCI xHCI hosts,
so move the CNR check to xhci_resume()
yeah, move that code to xhci_suspend(). It's valid for any XHCI host.
xhci_resume()
-Mathias
