Re: KMSAN: kernel-usb-infoleak in pcan_usb_pro_send_req

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 6, 2019 at 2:45 PM Oliver Neukum <oneukum@xxxxxxxx> wrote:
>
> Am Dienstag, den 30.07.2019, 02:38 -0700 schrieb syzbot:
> > Hello,
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:    41550654 [UPSTREAM] KVM: x86: degrade WARN to pr_warn_rate..
> > git tree:       kmsan
> > console output: https://syzkaller.appspot.com/x/log.txt?x=13e95183a00000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=40511ad0c5945201
> > dashboard link: https://syzkaller.appspot.com/bug?extid=513e4d0985298538bf9b
> > compiler:       clang version 9.0.0 (/home/glider/llvm/clang
> > 80fee25776c2fb61e74c1ecb1a523375c2500b69)
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17eafa1ba00000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17b87983a00000
> >
> > IMPORTANT: if you fix the bug, please add the following tag to the commit:
> > Reported-by: syzbot+513e4d0985298538bf9b@xxxxxxxxxxxxxxxxxxxxxxxxx
>
> #syz test: https://github.com/google/kasan.git 41550654

Hi Oliver,

For KMSAN bugs you'll need to use the kmsan tree (syz test:
https://github.com/google/kmsan.git COMMIT_ID). I've updated the
testing instructions some time ago to reflect this. Sorry for the
complexity, this is caused by USB fuzzing and KMSAN not being upstream
yet.

Thanks!

>
> From 6de76fa3df8aedc7a76dc0ecdea8308e38d4dccc Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oneukum@xxxxxxxx>
> Date: Tue, 6 Aug 2019 14:41:52 +0200
> Subject: [PATCH] pcan_usb_fd: zero out the common command buffer
>
> Lest we leak kernel memory to a device we better zero out buffers.
>
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
> ---
>  drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> index 34761c3a6286..47cc1ff5b88e 100644
> --- a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> +++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> @@ -841,7 +841,7 @@ static int pcan_usb_fd_init(struct peak_usb_device *dev)
>                         goto err_out;
>
>                 /* allocate command buffer once for all for the interface */
> -               pdev->cmd_buffer_addr = kmalloc(PCAN_UFD_CMD_BUFFER_SIZE,
> +               pdev->cmd_buffer_addr = kzalloc(PCAN_UFD_CMD_BUFFER_SIZE,
>                                                 GFP_KERNEL);
>                 if (!pdev->cmd_buffer_addr)
>                         goto err_out_1;
> --
> 2.16.4
>
>
>
> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@xxxxxxxxxxxxxxxx.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/1565095525.8136.22.camel%40suse.com.



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux