Re: [PATCH v1] usb: typec: tcpm: Switch to use fwnode_property_count_uXX()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 23, 2019 at 10:37:50PM +0300, Andy Shevchenko wrote:
> Use use fwnode_property_count_uXX() directly, that makes code neater.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index fba32d84e578..ec525811a9eb 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4410,8 +4410,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,
>  		goto sink;
>  
>  	/* Get source pdos */
> -	ret = fwnode_property_read_u32_array(fwnode, "source-pdos",
> -					     NULL, 0);
> +	ret = fwnode_property_count_u32(fwnode, "source-pdos");
>  	if (ret <= 0)
>  		return -EINVAL;
>  
> @@ -4435,8 +4434,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,
>  		return -EINVAL;
>  sink:
>  	/* Get sink pdos */
> -	ret = fwnode_property_read_u32_array(fwnode, "sink-pdos",
> -					     NULL, 0);
> +	ret = fwnode_property_count_u32(fwnode, "sink-pdos");
>  	if (ret <= 0)
>  		return -EINVAL;
>  
> -- 
> 2.20.1

thanks,

-- 
heikki



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux