On Mon, Jul 22, 2019 at 10:06:38AM +0000, Pawel Laszczak wrote: > Hi, > > > > >On Sun, 2019-07-21 at 19:32 +0100, Pawel Laszczak wrote: > >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > >> to driver/usb/common/debug.c file. These moved functions include: > >[] > >> diff --git a/drivers/usb/common/debug.c b/drivers/usb/common/debug.c > >[] > >> +static void usb_decode_set_clear_feature(__u8 bRequestType, __u8 bRequest, > >> + __u16 wValue, __u16 wIndex, > >> + char *str, size_t size) > > > >It's probably not necessary to use Hungarian > >when moving these functions into generic code. > > In my opinion it's ok in this place. It's consistence with USB specification ch9 and with > https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/usb/ch9.h. (look at usb_ctrlrequest). Yes, this is fine, the USB subsystem has this everywhere, and we all know exactly what it means when we see it. thanks, greg k-h
