Hi! > This patch introduce new Cadence USBSS DRD driver to linux kernel. > > The Cadence USBSS DRD Controller is a highly configurable IP Core which > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations. I see you are using debugfs to select between DRD, peripheral-onlyh and XHCI... Is that good idea? This is at least 3rd driver needing that capability, and debugfs does not sound like a good match. Pavel