Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 16, 2019 at 08:43:52PM -0500, Dan Williams wrote:
> On Tue, 2019-07-16 at 21:12 +0200, Rogan Dawes wrote:
> > Add device id for D-Link DWM-222.

> > @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = {
> >  	  .driver_info = RSVD(4) },
> >  	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff),			/* D-Link DWM-222 */
> >  	  .driver_info = RSVD(4) },
> > +	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e3d, 0xff),			/* D-Link DWM-222 A2 */
> > +	  .driver_info = RSVD(0) | RSVD(4) },
> 
> I don't think we actually do need to blacklist interface 0, since
> that's likely a QCDM/DIAG interface and that does need a serial driver
> like option or qcserial.
> 
> Johan, any reason why you thought we should blacklist 0?

It was just me being confused about the Qualcomm protocols and how the
diag port was accessed from user space. Thanks, Dan.

Rogan, let's keep interface 0 and only blacklist interface 4 as you did
originally. Sorry about the confusion.

Johan



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux