On Fri, Jul 5, 2019 at 1:22 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Jul 04, 2019 at 11:35:28AM -0400, Ryan Kennedy wrote: > > The AMD PLL USB quirk is incorrectly enabled on newer Ryzen > > chipsets. The logic in usb_amd_find_chipset_info currently checks > > for unaffected chipsets rather than affected ones. This broke > > once a new chipset was added in e788787ef. It makes more sense > > to reverse the logic so it won't need to be updated as new > > chipsets are added. Note that the core of the workaround in > > usb_amd_quirk_pll does correctly check the chipset. > > > > Signed-off-by: Ryan Kennedy <ryan5544@xxxxxxxxx> > > --- > > drivers/usb/host/pci-quirks.c | 31 +++++++++++++++++++------------ > > 1 file changed, 19 insertions(+), 12 deletions(-) > > Should this be backported to stable kernels? The bug is fairly harmless, so I wouldn't say it's a must-have. I only noticed this because I saw the log message and was curious what the quirk was for. The fix saves us calling usb_amd_quirk_pll() and taking the lock in there. Others here should know better than I what's stable worthy. Ryan > > thanks, > > greg k-h
