Re: [PATCH 2/4] USB: iuu_phoenix: Fix stopbit when uart goes on.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, May 27, 2009 at 11:53:19AM +0100, Alan Cox wrote:
> I've queued 1 and 2, and will queue 4 differently (the problem with
> calling it 0.10 is later a vendor 0.10 will appear and it gets confusing)
> 
> So if you are ok with that I'll name it 0.9ob ...

Perfect for me.

> Still looking at the termios bits. It should really be selecting as far
> as I can tell something like
> 
> 	CS8		1 stop	no parity
> 	CS7		2 stop  no parity
> 	CS7|PARENB	1 stop even parity
> 	CS7|PARENB|PARODD	1 stop odd parity
> 
> I'll have a look at that in a bit

maybe something like:

        parity = 0;
        if (cflag & CS8) {
                parity = IUU_ONE_STOP_BIT | IUU_PARITY_NONE;
        } else {
                parity |= (cflag & PARENB ?
                                (cflag & PARODD ? IUU_PARITY_ODD :
                                 IUU_PARITY_EVEN) :
                                IUU_PARITY_NONE);
                parity |= (cflag & CSTOPB ? IUU_TWO_STOP_BITS : IUU_ONE_STOP_BIT);
        }

and setting it back with:

        tty->termios->c_cflag |= cflag & (PARENB
                        | PARODD | CSTOPB | CS7 | CS8);

Thanks for taking into account these set of patches. It will make this device
working better.

        Olivier
-- 
Olivier Bornet
Olivier.Bornet@xxxxxxx
Swiss Ice Hockey Results : http://puck.ch/
Get my PGP-key at http://puck.ch/pgp or at http://pgp.mit.edu/

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux