Re: [PATCH] usb: storage: skip only when uas driver is loaded

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, den 02.07.2019, 14:56 +0800 schrieb JC Kuo:
> 
> Since blacklisting uas kernel module is not a good idea and could break UAS

Then don't do it. If you don't want a driver loaded for a device
blacklisting the driver must not magically assign another driver.

> capable storage functionality, do we consider forbidding making uas driver
> as module? That means to make CONFIG_USB_UAS a bool option.

No. Absolutely not. We cannot force people to build UAS into their
kernel or not use it. Building either driver not at all, modular
or statically are all valid use cases. Just not building UAS must
trigger a fallback. And we must have a flag to override the kernel's
decision

Making driver assignments depend on module loading order is a very bad
idea. We also have the necessary quirk in one way. I would accept a
patch adding a flag to force usage of UAS, but other than that, the
existing code is as it must be.

	Regards
		Oliver




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux