Re: [PATCH v2] usb: core: message: remove memset in usb_get_descriptor()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 29, 2019 at 04:40:11PM +0800, yuan linyu wrote:
> when below condition occur, the buf will be dirty again.
> if (result > 1 && ((u8 *)buf)[1] != type) {
> 	result = -ENODATA;
> 	continue;
> }
> so caller should check return length which indicate buffer valid or not.

I still fail to see what this means at all.

A changelog comment should explain what the problem is and why it is
being fixed in this way.

> 
> Signed-off-by: yuan linyu <cugyly@xxxxxxx>
> ---
>  drivers/usb/core/message.c | 2 --
>  1 file changed, 2 deletions(-)

Also you need to put what changed from a previous patch below the ---
line like the documentation states to do.

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux