Re: [PATCH] gpss: core: no waiters left behind on deregister

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

   The subject has gpss ISO gnss. You hardly meant the General Purpose
System Simulation. :-)

On 24.06.2019 11:33, Oliver Neukum wrote:

If you deregister a device you need to wake up all waiters
as there will be no further wakeups.

Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
---
  drivers/gnss/core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c
index e6f94501cb28..0d13bd2cefd5 100644
--- a/drivers/gnss/core.c
+++ b/drivers/gnss/core.c
@@ -303,7 +303,7 @@ void gnss_deregister_device(struct gnss_device *gdev)
  	down_write(&gdev->rwsem);
  	gdev->disconnected = true;
  	if (gdev->count) {
-		wake_up_interruptible(&gdev->read_queue);
+		wake_up_interruptible_all(&gdev->read_queue);
  		gdev->ops->close(gdev);
  	}
  	up_write(&gdev->rwsem);

MBR, Sergei



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux