On Thu, Jun 20, 2019 at 11:59:21PM -0700, dmg@xxxxxxxxxxxxxxxxx wrote: > From: Daniel M German <dmg@xxxxxxxxxxxxxxxxx> > > Replace ?: with min to calculate the number of bytes in the secondary buffer, > including changing the data type of data_in_secondary to size_t to be > type-consistent. data_in_secondary can never be negative. > > Remove some spurious calculations (copy_to_user returns zero on success), > making one variable redundant (i) > > This change does not alter the functionality of the code. > > Signed-off-by: Daniel M German <dmg@xxxxxxxxxxxxxxxxx> > --- > drivers/usb/misc/adutux.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) When sending a new version of a patch, you need to version it. The documentation says how to do this, but basically you need a "v2" in the subject line ([PATCH v2]) and then below the --- line, you need to say what has changed from the previous version. Can you resend a v3 of this patch that has all of that in it? thanks, greg k-h
