Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> On Mon, Jun 17, 2019 at 04:30:50PM -0700, dmg@xxxxxxxxxxxxxxxxx wrote:
>> From: Daniel M German <dmg@xxxxxxxxxxxxxxxxx>
>>
>> Use min_t to find the minimum of two values instead of using the ?: operator.
>
> Why is min_t() needed for all of these and not just min()?
The use of min triggers a compilation warning (see below), which min_t is supposed to
address (from min_t comment: 'min()/max() macros that also do strict type-checking.. See the
"unnecessary" pointer comparison.", from include/linux/kernel')
In file included from drivers/usb/misc/adutux.c:19:
drivers/usb/misc/adutux.c: In function ‘adu_read’:
./include/linux/kernel.h:818:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^~
./include/linux/kernel.h:832:4: note: in expansion of macro ‘__typecheck’
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~
./include/linux/kernel.h:842:24: note: in expansion of macro ‘__safe_cmp’
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~
./include/linux/kernel.h:851:19: note: in expansion of macro ‘__careful_cmp’
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~
drivers/usb/misc/adutux.c:382:34: note: in expansion of macro ‘min’
int amount = min(bytes_to_read, data_in_secondary);
^~~
[...]
> Can you break this up into one patch per driver? That way you can
> include the proper maintainers/reviewers when you resend them.
>
I will split the patch as instructed.
> thanks,
>
> greg k-h
--
Daniel M. German "Beauty is the first test; there is no
permanent place in the world for ugly
G. H. Hardy -> mathematics."
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .
