On Tue, May 26, 2009 at 12:09:48PM +0900, Yoshihiro Shimoda wrote: > +struct r8a66597_platdata { > + /* This ops can controll port power instead of DVSTCTR register. */ > + void (*port_power)(int port, int power); > + > + /* (external controller only) set R8A66597_PLATDATA_XTAL_nnMHZ */ > + unsigned xtal:2; > + > + /* set one = 3.3V, set zero = 1.5V */ > + unsigned vif:1; > + > + /* set one = big endian, set zero = little endian */ > + unsigned endian:1; > + > + /* set one = low level, set zero = falling edge */ > + unsigned irq_sense:1; > +}; I would just get rid of irq_sense entirely. You can OR in IRQF_TRIGGER_LOW or IRQF_TRIGGER_FALLING against IORESOURCE_IRQ in the struct resource, so there is no need for reproducing this information elsewhere. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html