On Thu, 2019-06-06 at 09:31 +0300, Andy Shevchenko wrote: > On Thu, Jun 6, 2019 at 5:53 AM Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> wrote: > > > > On Wed, 2019-06-05 at 11:45 +0300, Andy Shevchenko wrote: > > > On Wed, May 29, 2019 at 10:44 AM Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> wrote: > > > > > > > > Due to the requirement of usb-connector.txt binding, the old way > > > > using extcon to support USB Dual-Role switch is now deprecated > > > > when use Type-B connector. > > > > This patch introduces a driver of Type-B connector which typically > > > > uses an input GPIO to detect USB ID pin, and try to replace the > > > > function provided by extcon-usb-gpio driver > > > > > > > +static SIMPLE_DEV_PM_OPS(usb_conn_pm_ops, > > > > + usb_conn_suspend, usb_conn_resume); > > > > + > > > > +#define DEV_PMS_OPS (IS_ENABLED(CONFIG_PM_SLEEP) ? &usb_conn_pm_ops : NULL) > > > > > > Why this macro is needed? > > Want to set .pm as NULL when CONFIG_PM_SLEEP is not enabled. > > Doesn't SIMPLE_DEV_PM_OPS do this for you? Yes, you are right, it provides an empty dev_pm_ops struct, I'll remove DEV_PMS_OPS, thanks a lot >
