RE: [PATCH v4 2/5] i2c: nvidia-gpu: add runtime pm support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

> -----Original Message-----
> From: linux-i2c-owner@xxxxxxxxxxxxxxx <linux-i2c-owner@xxxxxxxxxxxxxxx>
> On Behalf Of Wolfram Sang
> Sent: Friday, June 7, 2019 1:33 AM
> To: Ajay Gupta <ajaykuee@xxxxxxxxx>
> Cc: heikki.krogerus@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-
> i2c@xxxxxxxxxxxxxxx; Ajay Gupta <ajayg@xxxxxxxxxx>
> Subject: Re: [PATCH v4 2/5] i2c: nvidia-gpu: add runtime pm support
> 
> 
> > +	pm_runtime_mark_last_busy(i2cd->dev);
> > +	pm_runtime_put_autosuspend(i2cd->dev);
> 
> Much better to have this only once!
> 
> > +/*
> > + * We need gpu_i2c_suspend() even if it is stub, for runtime pm to
> > +work
> > + * correctly. Without it, lspci shows runtime pm status as "D0" for the
> card.
> > + * Documentation/power/pci.txt also insists for driver to provide this:
> 
> I'd think the comment up to here is enough and the rest can go. However, I
> leave this decision to you.
Sure, will fix it.

Thanks
> nvpublic





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux